[PATCH] D75270: [DebugInfo] Do not emit entry values for composite locations

Thu Apr 30 03:57:48 PDT 2020

dstenb added a comment.

In D75270#2012177 <https://reviews.llvm.org/D75270#2012177>, @djtodoro wrote:

> Hi @dstenb,
>
> What is the status with this?

Sorry for leaving this!

This related a bit to D75326 <https://reviews.llvm.org/D75326>, and there I sent a mail to the Dwarf-Discuss mailing thread (http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2020-March/004610.html) about whether or not composite locations are allowed in DWARF Expressions.

@vsk, do you think it would be okay for you if we land this patch based on the similar reasoning as in you wrote in D75326 <https://reviews.llvm.org/D75326>? I mean this:

> Reading through the discussion, I do see some amount of consensus about the first sentence of section 2.5 being misleading (or at least confusing) -- this is the bit I cited in argument for allowing composite locations wherever a value is expected. I think we'd need a strong reason to disregard that consensus.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75270/new/

https://reviews.llvm.org/D75270