[PATCH] D78076: [mlir] Support big endian in DenseElementsAttr

Thu Apr 30 01:49:08 PDT 2020

ro added a comment.

In D78076#2011725 <https://reviews.llvm.org/D78076#2011725>, @imaihal wrote:

> Pre-merge check fails, but I'm not sure why this happens. Could you tell me how to resolve this? (I'm new about Phabricator and archanist. Excuse me if this is basic question)
>
> I see following error in build log.

[...]

  > Exception: Applying patch failed:
  > error: patch failed: mlir/lib/IR/Attributes.cpp:524
  > error: mlir/lib/IR/Attributes.cpp: patch does not apply

It's exactly as the error says: your patch doesn't apply cleanly to current master.  I noticed the problem myself when trying to re-test
the revised version on Solaris/SPARC:

- For one, the patch is an incremental one on top of your original patch.  This won't work: you need to upload a full patch instead.
- Even so, the original patch doesn't apply any longer, but needs to be rebased.

In short: create a complete patch that applies cleanly to current master and upload that.  You should be fine then.  At least my Solaris testing
after manually doing the same suggests so.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78076/new/

https://reviews.llvm.org/D78076