[PATCH] D78888: [llvm-objcopy][MachO] Fix symbol table

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/stab-ext-symbol.test:4-10
+## static int x = 0;
+## // Defined external symbol
+## int main() {
+##   return x;
+## }
+## build command:
+##   clang -g -fno-exceptions -fno-unwind-tables a.c -o a.exe
----------------
I wonder if you started from assembly whether you'd be able to reduce this test-case down further? It seems like many of the symbols are unnecessary, for example. I don't know enough about this to be able to assist unfortunately.

Also, is there any particular reason you can't just add this case to symbol-table.test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78888/new/

https://reviews.llvm.org/D78888