[PATCH] D79141: [RISCV] Better Split Stack Pointer Adjustment for RVC

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 01:12:44 PDT 2020


lenary marked 2 inline comments as done.
lenary added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/split-sp-adjust.ll:138
+; RV32IC-NEXT:    c.swsp ra, 252(sp)
+; RV32IC-NEXT:    c.addi4spn a0, sp, 8
+; RV32IC-NEXT:    call use_pointer
----------------
shiva0217 wrote:
> The stack didn't split for rv32c because the stack size is 256 which is equal to the limit. Should we choose a slightly greater stack size for stack_split_rv32_c test case?
Great catch - I forgot to update the tests when I tweaked the limits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79141/new/

https://reviews.llvm.org/D79141





More information about the llvm-commits mailing list