[PATCH] D78782: Add .debug_ranges support to the DWARF YAML.

[Greg Clayton via Phabricator via llvm-commits]

clayborg marked 4 inline comments as done.
clayborg added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/macho-DWARF-debug-ranges.yaml:96
+        reserved3:       0x00000000
+        content:         011101030E1305110155170000022E00030E110112060000032E00030E11011201000000
+      - sectname:        __debug_info
----------------
Higuoxing wrote:
> Since the content of `__debug_abbrev` is provided by `debug_abbrev` in `DWARF` entry below. I think the content field can be removed?
This is how obj2yaml converted my original mach-o file so I can't remove it.


================
Comment at: llvm/test/tools/obj2yaml/macho-DWARF-debug-ranges.yaml:109
+        reserved3:       0x00000000
+        content:         520000000400000000000801010000000400000000000000000000000000020D000000000000000000000020000000031700000000000000000000003000000000000000022100000000100000000000000010000000
+      - sectname:        __debug_ranges
----------------
Higuoxing wrote:
> Ditto.
This is how obj2yaml converted my original mach-o file so I can't remove it.


================
Comment at: llvm/test/tools/obj2yaml/macho-DWARF-debug-ranges.yaml:122
+        reserved3:       0x00000000
+        content:         0000000000000000200000000000000000000000000000003000000000000000FFFFFFFFFFFFFFFF00100000000000000000000000000000001000000000000000000000000000000000000000000000
+      - sectname:        __debug_str
----------------
Higuoxing wrote:
> Ditto.
This is how obj2yaml converted my original mach-o file so I can't remove it.


================
Comment at: llvm/test/tools/obj2yaml/macho-DWARF-debug-ranges.yaml:135
+        reserved3:       0x00000000
+        content:         002F746D702F6D61696E2E630073747269707065643100737472697070656432006D61696E00
+  - cmd:             LC_SYMTAB
----------------
Higuoxing wrote:
> `__debug_str`'s content can also be placed in `DWARF` entry below, which is easier to read and write.
> 
> ```
> DWARF:
>   debug_str:
>     - ''
>     - /tmp/main.c
>     - stripped
>     - stripped2
>     - main
> ```
This is how obj2yaml converted my original mach-o file so I can't remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78782/new/

https://reviews.llvm.org/D78782