[PATCH] D79145: Allow gep (select) combine with non-constant operands

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:1729
+  // Allow transformation either if both sizes are constant or if either
+  // refers to alloca to help SROA.
+  if (!(isa<Constant>(True) && isa<Constant>(False)) &&
----------------
arsenm wrote:
> demorgan this
JBTW, demorgan comment or logic?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79145/new/

https://reviews.llvm.org/D79145