[PATCH] D78270: [lld-macho] Support calls to functions in dylibs
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 29 22:09:39 PDT 2020
alexshap added inline comments.
================
Comment at: lld/MachO/Arch/X86_64.cpp:91
+ memcpy(buf, stubHelperHeader, sizeof(stubHelperHeader));
+ write32le(buf + 3, in.imageLoaderCache->addr - (in.stubHelper->addr + 7));
+ write32le(buf + 11, in.got->addr +
----------------
i'm wondering if we can replace these numbers (7, 11, 15, ... ) either with some expression (like sizeof(..) etc) or named constants or add comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78270/new/
https://reviews.llvm.org/D78270
More information about the llvm-commits
mailing list