[PATCH] D78788: [MLIR] Modify Analysis op conversion mode to emit errors for all unlegalizable operations.

[Lucy Fox via Phabricator via llvm-commits]

lucyrfox added inline comments.


================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:1575
+      /// An analysis conversion emits any errors that would occur if a full
+      /// conversion were attempted, but should continue on without failure
+      /// (i.e. performing a partial conversion).
----------------
rriddle wrote:
> I'm not sure we always want warnings here, seems like more of a DEBUG log. If a user is relying on an analysis conversion to help slice code that is supported by different backends, they may not care that certain operations weren't converted.
Removed these warnings.


================
Comment at: mlir/lib/Transforms/DialectConversion.cpp:1579
+      op->emitWarning() << "failed to legalize operation '" << op->getName()
+                        << "'";
+      return success();
----------------
mehdi_amini wrote:
> Do we need to warn here?
> Can we let signaling up to the client since we populate unlegalizableOps?
Agreed. Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78788/new/

https://reviews.llvm.org/D78788