[PATCH] D78988: [LTO] Suppress emission of the empty object file

[Kuan Hsu Chen (Zakk) via Phabricator via llvm-commits]

khchen updated this revision to Diff 261121.
khchen marked an inline comment as done.
khchen added a comment.

1. Add empty combined module checking before call backend()
2. Appling new approach, some testcasess need to updated and deleted. In checking module empty approach, it can suppress emitting optimzed empty combined module, but in new approach, it still emit combined module. I thought new approach behavior is acceptable. This case happend in linker-script-symbols-assign.ll.
3. Delete llvm/test/ThinLTO/X86/empty-object.ll. I misunderstood -thinlto-distributed-indexes option meaning. I add this case just becasue becuase I modified llvm-lto2. I think testing in empty-module.ll is enough. This patch focus on empty combined module, I think we don't need to comfirm "empty ThinLTO module" still be emitted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78988/new/

https://reviews.llvm.org/D78988

Files:
  lld/COFF/LTO.cpp
  lld/ELF/LTO.cpp
  lld/test/COFF/lto-obj-path.ll
  lld/test/COFF/pdb-thinlto.ll
  lld/test/ELF/lto/linker-script-symbols-assign.ll
  lld/test/ELF/lto/thinlto-obj-path.ll
  llvm/include/llvm/LTO/Config.h
  llvm/include/llvm/LTO/LTO.h
  llvm/lib/LTO/LTO.cpp
  llvm/test/ThinLTO/X86/empty-module.ll
  llvm/test/tools/gold/X86/thinlto.ll
  llvm/tools/gold/gold-plugin.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78988.261121.patch
Type: text/x-patch
Size: 9237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200430/58b19e0b/attachment.bin>