[PATCH] D78267: [InstCombine][SVE] Fix visitExtractElementInst for scalable type.

[Huihui Zhang via Phabricator via llvm-commits]

huihuiz added inline comments.


================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:296
+    // FIXME: ShuffleVectorInstruction ShuffleMask need to handle scalable type.
+    if (!EC.Scalable || EltNo < LHSWidth) {
+      int InEl = SVI->getMaskValue(EltNo);
----------------
efriedma wrote:
> "EltNo < LHSWidth" doesn't make any sense.
Update this fix. I think we should check if EltNo is recorded in shuffle mask before calling getMaskValue. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78267/new/

https://reviews.llvm.org/D78267