[PATCH] D78782: Add .debug_ranges support to the DWARF YAML.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added a comment.

Hi, I am not qualified to review, I leave some comments below :)



================
Comment at: llvm/test/tools/obj2yaml/macho-DWARF-debug-ranges.yaml:96
+        reserved3:       0x00000000
+        content:         011101030E1305110155170000022E00030E110112060000032E00030E11011201000000
+      - sectname:        __debug_info
----------------
Since the content of `__debug_abbrev` is provided by `debug_abbrev` in `DWARF` entry below. I think the content field can be removed?


================
Comment at: llvm/test/tools/obj2yaml/macho-DWARF-debug-ranges.yaml:109
+        reserved3:       0x00000000
+        content:         520000000400000000000801010000000400000000000000000000000000020D000000000000000000000020000000031700000000000000000000003000000000000000022100000000100000000000000010000000
+      - sectname:        __debug_ranges
----------------
Ditto.


================
Comment at: llvm/test/tools/obj2yaml/macho-DWARF-debug-ranges.yaml:122
+        reserved3:       0x00000000
+        content:         0000000000000000200000000000000000000000000000003000000000000000FFFFFFFFFFFFFFFF00100000000000000000000000000000001000000000000000000000000000000000000000000000
+      - sectname:        __debug_str
----------------
Ditto.


================
Comment at: llvm/test/tools/obj2yaml/macho-DWARF-debug-ranges.yaml:158-163
+    - ''
+    - ''
+    - ''
+    - ''
+    - ''
+    - ''
----------------
Are these empty strings used as placeholders? If not, I think they can be removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78782/new/

https://reviews.llvm.org/D78782