[PATCH] D79114: [lld-macho] Dylib symbols should always replace undefined symbols

[Jez Ng via Phabricator via llvm-commits]

int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/test/MachO/resolution.s:27-28
+## But defined symbols should take precedence.
+# OBJ-FIRST-NOT: libresolution _bar
+# OBJ-FIRST-NOT: libresolution _baz
+
----------------
smeenai wrote:
> Where are `_bar` and `_baz` defined in this assembly file?
ah, I was under the impression that I didn't need to define them because they were already appearing in the symtab, but I realize they were appearing as undefined symbols instead of the global/local defined symbols that I wanted. Will fix, thanks

> I believe we should already be implementing this behavior, courtesy of a Defined replacing any other symbol, but it's worth adding a test.

Yeah this is what _bar and _baz are supposed to test :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79114/new/

https://reviews.llvm.org/D79114