[PATCH] D79112: [SelectionDAG] Add the option of disabling generic combines.

Marcello Maggioni via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 14:00:47 PDT 2020


kariddi marked an inline comment as done.
kariddi added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1655
+  SDValue RV;
+  if (!STI || !STI->disableGenericCombines(OptLevel))
+    RV = visit(N);
----------------
arsenm wrote:
> Why call this for every node? Why not just once when the combiner is constructed?
That is a very good idea :) Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79112/new/

https://reviews.llvm.org/D79112





More information about the llvm-commits mailing list