[PATCH] D76869: [Clang] Restore replace_path_prefix instead of startswith
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 29 14:00:44 PDT 2020
MaskRay added inline comments.
================
Comment at: llvm/lib/Support/Path.cpp:510
+ return false;
+ if (!SepPath && toLower(Path[I]) != toLower(Prefix[I]))
+ return false;
----------------
MaskRay wrote:
> I am sure toLower works when Unicode is considered.
>
> @amccarth has made many useful comments in this area before, so I added him as a blocking reviewer.
s/am sure/am not sure/
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76869/new/
https://reviews.llvm.org/D76869
More information about the llvm-commits
mailing list