[PATCH] D79083: [CodeGen] Fix warnings due to SelectionDAG::getSplatSourceVector

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 12:54:57 PDT 2020


fpetrogalli added a comment.

Hi @david-arm ,

I think you could tests some of these methods of `SelectionDAG` directly like it has been done in `llvm/unittest/CodeGen/AArch64SelectionDAGTest.cpp`.

You can reuse the infrastructure in there to create the DAG instance, and from there build the values you want to test for the methods you have modified.

Francesco


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79083/new/

https://reviews.llvm.org/D79083





More information about the llvm-commits mailing list