[PATCH] D79011: [mlir] Extract DictionaryAttr sort method

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/include/mlir/IR/OperationSupport.h:314
+  /// Sorts the NamedAttributes.
+  void sortAttributes() { DictionaryAttr::sort(attributes); }
+
----------------
Can we defer this until it is needed?


================
Comment at: mlir/lib/IR/Attributes.cpp:111
+                               SmallVectorImpl<NamedAttribute> &storage) {
+  if (inPlace)
+    value = storage;
----------------
Can we remove this now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79011/new/

https://reviews.llvm.org/D79011