[PATCH] D78535: libclc: Pass system libraries to the linker after llvm libraries

Wed Apr 29 11:49:19 PDT 2020

tstellar added a comment.

In D78535#2000814 <https://reviews.llvm.org/D78535#2000814>, @jvesely wrote:

> In D78535#1999173 <https://reviews.llvm.org/D78535#1999173>, @tstellar wrote:
>
> > In D78535#1998136 <https://reviews.llvm.org/D78535#1998136>, @jvesely wrote:
> >
> > > was this a problem with using `-Wl,--as-needed`?
> > >
> > > LGTM.
> >
> >
> > No, I was hitting this when using the default build options for both LLVM and libclc.
>
>
> that's weird. linker shouldn't really drop libraries unless as-needed is used. can you post the falling cmdline?

This is the failing cmdline (from here https://github.com/tstellar/llvm-project/runs/587088911):

/usr/bin/c++     CMakeFiles/prepare_builtins.dir/utils/prepare-builtins.cpp.o  -o prepare_builtins -L/home/runner/work/llvm-project/llvm-project/build/lib -Wl,-rpath,/home/runner/work/llvm-project/llvm-project/build/lib  -lz -lrt -ldl -ltinfo -lpthread -lm -lxml2  -lLLVMBitWriter -lLLVMAnalysis -lLLVMProfileData -lLLVMObject -lLLVMTextAPI -lLLVMMCParser -lLLVMMC -lLLVMDebugInfoCodeView -lLLVMDebugInfoMSF -lLLVMBitReader -lLLVMCore -lLLVMRemarks -lLLVMBitstreamReader -lLLVMBinaryFormat -lLLVMSupport -lLLVMDemangle

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78535/new/

https://reviews.llvm.org/D78535