[PATCH] D79103: Fix ELF/linkerscript/input-archive.s w/ @ in path

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 10:11:24 PDT 2020


thopre created this revision.
thopre added reviewers: jhenderson, MaskRay, evgeny777, espindola, alexshap.
thopre added a project: LLVM.
Herald added a subscriber: emaste.

Lld test ELF/linkerscript/input-archive.s fails when path contain a @
because @ is a keyword in linker script which leads to the path being
broken in 2 around the @. This commit quotes the path used in the linker
script created by the testcase allowing the test to pass even in the
presence of an @ sign in the path.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79103

Files:
  lld/test/ELF/linkerscript/input-archive.s


Index: lld/test/ELF/linkerscript/input-archive.s
===================================================================
--- lld/test/ELF/linkerscript/input-archive.s
+++ lld/test/ELF/linkerscript/input-archive.s
@@ -11,7 +11,7 @@
 ## *.a:b.o matches /path/to/input-archive.s.tmp.a:b.o
 ## *b.o matches /path/to/input-archive.s.tmp.a:b.o
 # RUN: echo 'SECTIONS { \
-# RUN:   .foo : { %t.a:a.o(.data) } \
+# RUN:   .foo : { "%t.a:a.o"(.data) } \
 # RUN:   .bar : { *.a:b.o(.data) } \
 # RUN:   .qux : { *b.o(.data1) } \
 # RUN:   }' > %t.script


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79103.260950.patch
Type: text/x-patch
Size: 540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200429/17778404/attachment.bin>


More information about the llvm-commits mailing list