[PATCH] D79042: [llvm] Add interface to drive inlining decision using ML model

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 10:11:23 PDT 2020


mtrofin marked an inline comment as done and an inline comment as not done.
mtrofin added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ML/InliningAdvisor.h:50
+  virtual std::unique_ptr<PendingInliningRecord>
+  shouldInline(CallBase *CB, bool &AlternativeRecommendation, bool Mandatory,
+               int CostEstimate) = 0;
----------------
davidxl wrote:
> nit: shouldInline --> getInlineAdvise?
sure - I'll leave this open until the review gets closer to the end, since it's easy to refactor, and I'd just want to do it once.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79042/new/

https://reviews.llvm.org/D79042





More information about the llvm-commits mailing list