[PATCH] D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 09:06:14 PDT 2020


sfertile added a comment.

Have you considered not transforming ExternalSymbolSDNodes, but instead supporting them for AIX and then creating the symbol and emitting the linkage for the ExternalSymbol machine operand in the ASMPrinter? The approach this patch takes adds complexity to a target independent part of the MC infrastructure.  The amount of complexity it adds is not unreasonable, but I think if we can contain the complexity to the PowerPC backend its worth considering strongly even if the implementation there is more difficult.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78929/new/

https://reviews.llvm.org/D78929





More information about the llvm-commits mailing list