[PATCH] D79084: [VE] Dynamic stack allocation

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 08:33:16 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.cpp:556
+  const VEInstrInfo &TII =
+      *static_cast<const VEInstrInfo *>(MF.getSubtarget().getInstrInfo());
+  DebugLoc dl = MBB->findDebugLoc(MI);
----------------
getSubtarget<VESubtarget> and remove the cast. You also added Subtarget as a member, so you don't need the get anyway


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.cpp:564
+  const MachineFrameInfo &MFI = MF.getFrameInfo();
+  const TargetFrameLowering *TFL = MF.getSubtarget().getFrameLowering();
+
----------------
getSubtarget<VESubtarget>() and use the VEFrameLowering?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79084/new/

https://reviews.llvm.org/D79084





More information about the llvm-commits mailing list