[PATCH] D79074: [PowerPC] Respect SDNodeFlags in lowering SELECT_CC

Qiu Chaofan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 29 02:38:51 PDT 2020


qiucf created this revision.
qiucf added reviewers: steven.zhang, jsji, nemanjai, ZhangKang, PowerPC.
Herald added subscribers: llvm-commits, shchenz, kbarton, hiraditya.
Herald added a project: LLVM.
qiucf added a child revision: D78989: [NFC] [PowerPC] Narrow fast-math flags in tests.
Herald added a subscriber: wuzish.
qiucf marked an inline comment as done.
qiucf added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/scalar-min-max.ll:131
 entry:
-  %cmp = fcmp fast ogt float %a, %b
+  %cmp = fcmp ogt float %a, %b
   %cond = select i1 %cmp, float %a, float %b
----------------
Deleting `fast` in this file looks okay to me, since we already used command-line flags. We can clear this in following patches.


Legalizer should respect both command-line options or SDNode-level fast-math flags.

Also, this patch propagates other flags during custom simplifying.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79074

Files:
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/test/CodeGen/PowerPC/scalar-equal.ll
  llvm/test/CodeGen/PowerPC/scalar-min-max.ll
  llvm/test/CodeGen/PowerPC/scalar_cmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79074.260865.patch
Type: text/x-patch
Size: 56942 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200429/93365f93/attachment.bin>


More information about the llvm-commits mailing list