[PATCH] D78950: Adds LRU caching of compile units in DWARFContext.

[Pavel Labath via Phabricator via llvm-commits]

labath added reviewers: JDevlieghere, probinson.
labath added a comment.

(adding more debug info folks)

In D78950#2008973 <https://reviews.llvm.org/D78950#2008973>, @netforce wrote:

> Do you think this is better in terms of keeping the API flexible enough?


Umm... probably?

I don't have a comprehensive overview of the users of the DWARF parser either, but I'm sure there are users that want to access it through the lower level APIs. Lldb will most likely be one of those users -- even after it starts using llvm parsers completely I think it's fairly unlikely it would use APIs like `getLocalsForAddress`, but rather do something custom. However, all of that is vapourware, so its hard to reason about that.

It may be more interesting to look at other (real) users. One such user which comes to mind is (llvm-)dsymutil, as it accesses dwarf in a fairly complex way. Jonas, what do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78950/new/

https://reviews.llvm.org/D78950