[PATCH] D78920: [llvm-readobj] [COFF] Cope with debug directory payloads in unmapped areas

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked 2 inline comments as done.
mstorsjo added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/COFF/debug-directory-unmapped.test:1-4
+# Test that printing debug directories that aren't part of the runtime
+# mapped sections doesn't fail. (Currently only printing the entry itself
+# but not the payload - and this test doesn't currently include any
+# meaningful data where it claims that the debug entry payload is.)
----------------
jhenderson wrote:
> Could you use '##' for the comment markers, please. This is a practice I'm encouraging in my reviews, as it helps comments stand out from the lit/FileCheck directives.
> 
> Also I'd change the bit in brackets to "Currently llvm-readobj only prints the entry itself and not the payload. Note that there isn't currently any meaningful data in this test input where it claims the debug entry payload is." and probably just get rid of the brackets.
Sure, will fix before pushing. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78920/new/

https://reviews.llvm.org/D78920