[PATCH] D78921: [llvm-objcopy] [COFF] Fix a misconception about debug directory payloads

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one request.



================
Comment at: llvm/test/tools/llvm-objcopy/COFF/debug-dir-unmapped.test:1-3
+# Check that we error out when trying to patch up debug directories that
+# point to data outside of the runtime mapped sections (as we don't try to
+# locate and copy such payloads from the padding areas of the input file).
----------------
'##' to distinguish from lit and FileCheck directives, please.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/patch-debug-dir2.test:1-2
+# Check that we successfully patch the PointerToRawData field in more than
+# one debug directory entry.
+
----------------
Ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78921/new/

https://reviews.llvm.org/D78921