[PATCH] D78805: [llvm-readobj][test] - Stop using binaries in gnu-phdrs.test, split and refine it.

[George Rimar via Phabricator via llvm-commits]

grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-section-mapping.test:11-12
+# MAPPING-NEXT:  Segment Sections...
+# MAPPING-NEXT:   00     .foo.begin .foo.end {{$}}
+# MAPPING-NEXT:   01     .bar.begin .bar.end {{$}}
+# MAPPING-NEXT:   None   .strtab .shstrtab {{$}}
----------------
jhenderson wrote:
> I suspect we might want a few more test-cases here. Some examples off the top of my head:
> 
> * Sections in segments which are themselves inside other segments.
> * TLS segment + trailing .tbss
> * Other nobits sections (both in middle and at end of segments).
> * Empty sections at start/middle/ends of segments
> * Sections that only partly overlap a segment (i.e. their start is before the start of a segment and/or their end is after the end of a segment).
> * Sections in a segment by address but not offset.
> * Sections in a segment by offset but not address.
> 
> There may well be others that I haven't thought of.
The original test also did not test all of that.

I mentioned it in the description:

```
I am going to use it as a base for a follow-up patch that should also test
section to segment mapping conditions that we currently have
(see the discussion in D78709)
```




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78805/new/

https://reviews.llvm.org/D78805