[PATCH] D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

Thanks!
LGTM with the other comments addressed



================
Comment at: mlir/lib/Transforms/BufferPlacement.cpp:366
+      placements.emplace_back(
+          allocResult, analysis.computeAllocAndDeallocPositions(allocResult));
       return WalkResult::advance();
----------------
Technically I we could have ops allocating two results, seems like you would only see the first?
We may miscompile in such cases I think, can we not try to move such ops if we see them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78993/new/

https://reviews.llvm.org/D78993