[PATCH] D78315: [mlir][Pass] Register a signal handler when generating crash reproducers.

[River Riddle via Phabricator via llvm-commits]

rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/lib/Pass/Pass.cpp:615
+  llvm::sys::SmartScopedLock<true> producerLock(*reproducerMutex);
+  assert(reproducerContext == this && "invalid context");
+  reproducerContext = nextContext;
----------------
mehdi_amini wrote:
> So this seems to enforce that we always delete the stack of RecoveryReproducerContext in the order in which they were created, how does it happen? If multiple threads from the application are running different PassManagers for example?
Ooops, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78315/new/

https://reviews.llvm.org/D78315