[PATCH] D79064: [test-suite] Register result codes with lit.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur created this revision.
Meinersbur added reviewers: yln, jdoerfert, arichardson, cmatthews, jdenny, rnk.
Herald added a subscriber: kristof.beyls.
Meinersbur updated this revision to Diff 260830.
Meinersbur added a comment.

- Missing Executables -> Executable Missing

When reporting test codes, lit appends " Test" to the category name.
I think "Executable Missing Tests" is better than "Missing Executables Tests".


lit currently only has a hard-coded set of result codes and crashes when encountering test-suite's NOEXE result code. D78164 <https://reviews.llvm.org/D78164> adds the possibility to register custom result codes.

This patch registers the result code NOEXE and reuses lit's SKIPPED result code.

While this does not fix any buildbot (such as http://lab.llvm.org:8011/builders/clang-native-arm-lnt-perf), it at least should allow lit to display which tests have failed at the end.


Repository:
  rT test-suite

https://reviews.llvm.org/D79064

Files:
  litsupport/test.py


Index: litsupport/test.py
===================================================================
--- litsupport/test.py
+++ litsupport/test.py
@@ -13,9 +13,10 @@
 import os
 
 
-SKIPPED = lit.Test.ResultCode('SKIPPED', False)
-NOEXE = lit.Test.ResultCode('NOEXE', True)
+SKIPPED = lit.Test.SKIPPED
 
+NOEXE = lit.Test.ResultCode('NOEXE', True)
+lit.main.add_result_category(NOEXE, "Executable Missing")
 
 class TestSuiteTest(lit.formats.ShTest):
     def __init__(self):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79064.260830.patch
Type: text/x-patch
Size: 469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200429/fdc8ac36/attachment.bin>