[PATCH] D79023: [mlir][vector] let transfer_read and transfer_write take non-zero addrspace.

Wen-Heng (Jack) Chung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 15:07:22 PDT 2020


whchung marked 2 inline comments as done.
whchung added inline comments.


================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:837
 
     // 1. Get the source/dst address as an LLVM vector pointer.
     // TODO: support alignment when possible.
----------------
aartbik wrote:
> This step 1. can use a bit more documentation now that it has become more eleborate
@aartbik just added more comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79023/new/

https://reviews.llvm.org/D79023





More information about the llvm-commits mailing list