[PATCH] D79031: [GlobalISel] Assign the correct debug location when combining G_SEXT/G_ANYEXT/G_ZEXT

[Daniel Sanders via Phabricator via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.

LGTM but double check -verify-machineinstrs works with -run-pass



================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/combine-ext-debugloc.mir:1
+# RUN: llc -O0 -mtriple aarch64-- -run-pass=legalizer %s -o - | FileCheck %s
+
----------------
paquette wrote:
> Should this have -verify-machineinstrs?
Also, does it actually run? It used to be the case that `-start-before=X -stop-after=X` ran it but `-run-pass=X` didn't. I don't remember off-hand whether that got fixed


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/combine-ext-debugloc.mir:40-50
+registers:
+  - { id: 0, class: _, preferred-register: '' }
+  - { id: 1, class: _, preferred-register: '' }
+  - { id: 2, class: _, preferred-register: '' }
+  - { id: 3, class: _, preferred-register: '' }
+  - { id: 4, class: _, preferred-register: '' }
+  - { id: 5, class: _, preferred-register: '' }
----------------
The 'registers' section can be safely removed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79031/new/

https://reviews.llvm.org/D79031