[PATCH] D78458: [LAA] Move CheckingPtrGroup/PointerCheck outside class (NFC).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 14:34:33 PDT 2020


fhahn marked an inline comment as done.
fhahn added a comment.

Thanks Ayal & Adam!



================
Comment at: llvm/lib/Transforms/Utils/LoopVersioning.cpp:48
 void LoopVersioning::setAliasChecks(
-    SmallVector<RuntimePointerChecking::PointerCheck, 4> Checks) {
+    SmallVector<RuntimePointerCheck, 4> Checks) {
   AliasChecks = std::move(Checks);
----------------
Ayal wrote:
> Unrelated, while we're here: better use SmallVectorImpl or ArrayRef instead of returning, constructing and moving SmallVector<4>'s?
Will do in a follow up, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78458/new/

https://reviews.llvm.org/D78458





More information about the llvm-commits mailing list