[PATCH] D79031: [GlobalISel] Assign the correct debug location when combining G_SEXT/G_ANYEXT/G_ZEXT

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 14:02:43 PDT 2020


vsk added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/combine-ext-debugloc.mir:8-9
+--- |
+  target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
+  target triple = "arm64-apple-ios13.0.0"
+  
----------------
davide wrote:
> paquette wrote:
> > Probably can just remove this?
> Just afraid it might freak out when run on linux, but I guess passing `-mtriple` explicitly overrides the setting?
IME the target data layout & triple sometimes do matter, as some builders may be configured with different assumptions about what these are by default.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79031/new/

https://reviews.llvm.org/D79031





More information about the llvm-commits mailing list