[PATCH] D79030: [mlir][DeclareOpInterfaceMethods] Allow specifying a set of methods to force declaration generation for.

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 14:02:37 PDT 2020


jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.

Thanks, so we have

- no default -> generate declaration
- default -> if ("op wants to specialize this") then generate declaration -> don't generate def

I was trying to think of what is the common case (wrt white list or black list approach), but probably if there is a default then it is the common case and so this should be least typing :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79030/new/

https://reviews.llvm.org/D79030





More information about the llvm-commits mailing list