[PATCH] D79021: [mlir][rocdl] refactor ROCDL dialect.

[Wen-Heng (Jack) Chung via Phabricator via llvm-commits]

whchung added a comment.

@rriddle Could you help elaborate how you envision `GPUFuncOpLowering::matchAndRewrite` be broken up? I'm less inclined to so as:

1. The logic is directly moved from `LowerGpuOpsToNVVMOps.cpp` as it's mostly common between NVVM and ROCDL dialect, other than the fact that alloca takes place on different address spaces. And additional logic and tests were already introduced in the patch.
2. The logic is self-contained with no additional consumers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79021/new/

https://reviews.llvm.org/D79021