[PATCH] D78867: docs: update 'arc land' command

Sergei Trofimovich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 10:44:42 PDT 2020


trofi marked an inline comment as done.
trofi added a comment.

In D78867#2007155 <https://reviews.llvm.org/D78867#2007155>, @sylvestre.ledru wrote:

> are you sure? D<revision> worked for me in the past


I copied `arc` output right from the terminal. Maybe I'm missing some configuration or `arc` behaviour changed.



================
Comment at: llvm/docs/Phabricator.rst:224
 
-  arc land D<Revision>
+  arc land arcpatch-D<Revision>
 
----------------
mehdi_amini wrote:
> I didn't know we were documenting `arc land`, I think we should discourage it heavily instead.
> 
> This is creating commit message with a lot of cruft inside: all the Phabricator tags should be removed before pushing IMO.
> 
Oh, TIL.

I can reword the section to avoid `arc land`. Would you be fine to review it or maybe you can suggest someone else as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78867/new/

https://reviews.llvm.org/D78867





More information about the llvm-commits mailing list