[PATCH] D78076: [mlir] Support big endian in DenseElementsAttr
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 28 10:44:38 PDT 2020
rriddle added a comment.
In D78076#2008053 <https://reviews.llvm.org/D78076#2008053>, @imaihal wrote:
> In D78076#1991377 <https://reviews.llvm.org/D78076#1991377>, @rriddle wrote:
>
> > Is there any way you can add a test for this?
>
>
> Many MLIR test such as "mlir/IR/attributes.mlir" fail on big-endian system, but they are fixed by using this patch.
> Should I add additional test for this patch?
If the tests already fail and get fixed, +1 on just submitting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78076/new/
https://reviews.llvm.org/D78076
More information about the llvm-commits
mailing list