[PATCH] D79019: [mlir][llvm] allow mlir-translate carry custom triple and data layout.

Tue Apr 28 10:44:33 PDT 2020

ftynse accepted this revision.
ftynse added a subscriber: aartbik.
ftynse added a comment.
This revision is now accepted and ready to land.

Thanks, I have been discussing a similar change with @aartbik just today. Please add the test on translation and feel free to land.

As an improvement (fine for a follow-up), could you please expose the triple and data layout as `mlir-translate` command line options?

================
Comment at: mlir/lib/Target/LLVMIR/ConvertToROCDLIR.cpp:81
+  auto amdgcnDataLayout =
+      "e-p:64:64-p1:64:64-p2:32:32-p3:32:32-p4:64:64-p5:32:32-p6:32:32-i64:64-"
+      "v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:"
----------------
Could you add a test that the LLVM module indeed has the specified triple and target and put it under `test/Target` ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79019/new/

https://reviews.llvm.org/D79019