[PATCH] D79025: Drop incorrect comment.

Wen-Heng (Jack) Chung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 10:44:33 PDT 2020


whchung created this revision.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: herhut.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79025

Files:
  mlir/lib/Conversion/GPUCommon/GPUOpsLowering.h


Index: mlir/lib/Conversion/GPUCommon/GPUOpsLowering.h
===================================================================
--- mlir/lib/Conversion/GPUCommon/GPUOpsLowering.h
+++ mlir/lib/Conversion/GPUCommon/GPUOpsLowering.h
@@ -123,9 +123,6 @@
         assert(type && type.hasStaticShape() &&
                "unexpected type in attribution");
 
-        // Explicitly drop memory space when lowering private memory
-        // attributions since NVVM models it as `alloca`s in the default
-        // memory space and does not support `alloca`s with addrspace(5).
         auto ptrType = typeConverter.convertType(type.getElementType())
                            .cast<LLVM::LLVMType>()
                            .getPointerTo(AllocaAddrSpace);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79025.260691.patch
Type: text/x-patch
Size: 750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200428/c7cd8edd/attachment-0001.bin>


More information about the llvm-commits mailing list