[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 260650.
SouraVX added a comment.

Addressed review comments by @ikudrin . Thanks for this!
Following changes have been made to this revision-

- Refactoring front  based on comment by @ikudrin -
  - In an effort to simplify the public interfacing of `macro/macinfo`,( which is currently used by  `DWARFContext`). public member function `parse` and private member function `parseImpl`(to do actual parsing)  are introduced in class `DWARFDebugMacro`.  This approach simplifies the interfacing to `DWARFContext`  to some extent(atleast parameter passing and readeability).
  - Also included a FIXME, as a hint that we should introduce a better abstraction.

On testing front -

- Previously we're asserting for a malformed user provided input, that has been switched to error handling. As a result 2 test cases were also added to verify these error messages.
- Furthermore test case is further reduced based on @ikudrin suggestion. Thanks for this, it helped a lot, now test case is more readable asm then previous.

- Lastly, I'll be revising other patches specifically `D78500`, After we reach consensus on the changes in this revision.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78736/new/

https://reviews.llvm.org/D78736

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macro-empty-macro-offset.s
  llvm/test/DebugInfo/X86/debug-macro-empty-str-offset.s
  llvm/test/DebugInfo/X86/debug-macro-multi-cu-strx.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78736.260650.patch
Type: text/x-patch
Size: 14939 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200428/561771b3/attachment.bin>