[PATCH] D78720: [globalopt] Don't emit DWARF fragments for members of a struct that cover the whole struct

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 28 09:06:37 PDT 2020


nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

ah got it, thanks for updating the comment, it makes more sense to me now.

Minor nits on the comments (sorry to bikeshed those), but LGTM.



================
Comment at: llvm/test/DebugInfo/Generic/global-sra-struct-zero-length.ll:7
+;     long b;
+;       a c
+; } d;
----------------
indentation and missing semicolon


================
Comment at: llvm/test/DebugInfo/Generic/global-sra-struct-zero-length.ll:11
+;     long f = d.b + 1;
+;       d.b = f;
+; }
----------------
indentation


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78720/new/

https://reviews.llvm.org/D78720





More information about the llvm-commits mailing list