[PATCH] D78968: [llvm][utils] Update llc test updater documentation

[Zola Bridges via Phabricator via llvm-commits]

zbrid added a comment.

In D78968#2007501 <https://reviews.llvm.org/D78968#2007501>, @RKSimon wrote:

> If this is a problem we should be doing more than just adding a comment in the script.
>
> Possible things to consider:
>  1 - add support for matching dso_preemptable  / dso_local - pretty trivial to add the relevant regex(s)
>  2 - detect any specifiers and warn that it might not be necessary


Hi @RKSimon ,

That's a good point. I agree that it better if this is fixed in the script, however I can't fix it right now and I think that this comment is useful in the meantime. I filed a bug and updated the comment to reference it: https://bugs.llvm.org/show_bug.cgi?id=45714. The comment can be removed at the point this is fixed.

Given that multiple people have encountered this bug, it seems worthwhile to add a comment until the point it's fixed, so they don't have to spend time reaching out to people or reading the script until they understand the lack of output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78968/new/

https://reviews.llvm.org/D78968