[PATCH] D78994: [Target][ARM] Add a fix for an LSR Pattern that can't be tail-predicated

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:199
+  BasicBlock *BodyBB = L->getHeader();
+  BasicBlock *LoopPredBB = L->getLoopPredecessor();
+
----------------
I think getLoopPreheader() would be preferable.


================
Comment at: llvm/lib/Target/ARM/MVETailPredication.cpp:326
 
+  FixLSRPattern(L, *SE);
+
----------------
We haven't even inserted the VCTP yet! Your test shouldn't contain the intrinsic. If TryConvert returns the VCTP, then you could use it directly and not have to iterate through the loop doing your add search.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78994/new/

https://reviews.llvm.org/D78994