[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

[Sam McCall via Phabricator via llvm-commits]

sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:22
+
+    DONT_CHECK_FILE_LIST
     )
----------------
would be nice to avoid specifying this here if it's not needed


================
Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:8
   )
-target_compile_definitions(clangd-index-server PRIVATE -D GOOGLE_PROTOBUF_NO_RTTI=1)
-clang_target_link_libraries(clangd-index-server
----------------
why this removal?


================
Comment at: llvm/cmake/modules/AddLLVM.cmake:412
   cmake_parse_arguments(ARG
-    "MODULE;SHARED;STATIC;OBJECT;DISABLE_LLVM_LINK_LLVM_DYLIB;SONAME;NO_INSTALL_RPATH;COMPONENT_LIB"
+    "MODULE;SHARED;STATIC;OBJECT;DISABLE_LLVM_LINK_LLVM_DYLIB;SONAME;NO_INSTALL_RPATH;COMPONENT_LIB;DONT_CHECK_FILE_LIST"
     "OUTPUT_NAME;PLUGIN_TOOL;ENTITLEMENTS;BUNDLE_PATH"
----------------
why do you need to parse this and then explicitly pass it through, rather than just letting it fall into ARG_UNPARSED_ARGUMENTS?


================
Comment at: llvm/cmake/modules/LLVMProcessSources.cmake:60
 function(llvm_process_sources OUT_VAR)
-  cmake_parse_arguments(ARG "" "" "ADDITIONAL_HEADERS;ADDITIONAL_HEADER_DIRS" ${ARGN})
+  cmake_parse_arguments(ARG "DONT_CHECK_FILE_LIST" "" "ADDITIONAL_HEADERS;ADDITIONAL_HEADER_DIRS" ${ARGN})
   set(sources ${ARG_UNPARSED_ARGUMENTS})
----------------
This name could be better, I think.

What about PARTIAL_SOURCES_INTENDED?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78885/new/

https://reviews.llvm.org/D78885