[PATCH] D78993: [mlir] Removed tight coupling of BufferPlacement pass to Alloc and Dealloc operations by using MemoryEffectOpInterface queries.
Stephan Herhut via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 28 06:24:15 PDT 2020
herhut accepted this revision.
herhut added a comment.
This revision is now accepted and ready to land.
Please wait for @mehdi_amini to take a look.
================
Comment at: mlir/lib/Transforms/BufferPlacement.cpp:361
+ if (allocateEffectInstance == effects.end())
+ return WalkResult::advance();
+
----------------
Would just `return` work?
================
Comment at: mlir/lib/Transforms/BufferPlacement.cpp:378
emitError(alloc.getLoc(),
"Not supported number of associated dealloc operations");
+ return;
----------------
Nit: Error messages start lower case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78993/new/
https://reviews.llvm.org/D78993
More information about the llvm-commits
mailing list