[PATCH] D74729: [FPEnv] Intrinsic for setting rounding mode

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/docs/LangRef.rst:18120
+
+These functions read or write floating point environment, such as rounding
+mode or state of floating point exceptions. 
----------------
Remove "read or " ?


================
Comment at: llvm/docs/LangRef.rst:18146-18150
+    0  - toward zero
+    1  - to nearest, ties to even
+    2  - toward positive infinity
+    3  - toward negative infinity
+    4  - to nearest, ties away from zero
----------------
arsenm wrote:
> I'm wondering if this should be more opaque, and broader for the entire FP environment (not just the rounding mode). For AMDGPU we have a number of additional bits in the FP environment. We also have the denormal mode, enabling FP exceptions, and a few more exotic target specific FP mode bits.
@arsenm Would these extra bits be exclusive modes or would you need this to support target specific mode combos?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74729/new/

https://reviews.llvm.org/D74729