[PATCH] D78987: [BPI][NFC] Reuse post dominantor tree from analysis manager when available
Serguei Katkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 28 04:15:37 PDT 2020
skatkov added inline comments.
================
Comment at: llvm/include/llvm/Analysis/BranchProbabilityInfo.h:139
void calculate(const Function &F, const LoopInfo &LI,
- const TargetLibraryInfo *TLI = nullptr);
+ const TargetLibraryInfo *TLI, PostDominatorTree *PDT);
----------------
why not nullptr by default?
================
Comment at: llvm/lib/Analysis/OptimizationRemarkEmitter.cpp:40
BranchProbabilityInfo BPI;
- BPI.calculate(*F, LI);
+ BPI.calculate(*F, LI, nullptr, nullptr);
----------------
If nullptr by default above, no need in this change...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78987/new/
https://reviews.llvm.org/D78987
More information about the llvm-commits
mailing list