[PATCH] D78806: SplitIndirectBrCriticalEdges: Fix Branch Probability update
Evgeniy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 28 03:43:28 PDT 2020
ebrevnov added a comment.
Functionally the change looks ok.
I think we should improve current API of BP (not in this change though) because it's easy to break invariant that sum of all probabilities is 1.
We better disallow cases when only part of edges have probability set and others unset. 1/NumSuccesors will likely be incorrect value in most cases with uneven distribution.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78806/new/
https://reviews.llvm.org/D78806
More information about the llvm-commits
mailing list