[PATCH] D78698: [VE] Implements minimum MC layer for VE

[Kazushi Marukawa via Phabricator via llvm-commits]

kaz7 marked 2 inline comments as done.
kaz7 added a comment.

Thanks for the comments.



================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:246
 }
+// AS assembly instrcution format:
+def VEMEMriAsmOperand : AsmOperandClass {
----------------
simoll wrote:
> typo 
Thanks.  I'll fix it in divided patch.


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:261
 def brtarget32 : Operand<OtherVT> {
-  let EncoderMethod = "getBranchTarget32OpValue";
 }
----------------
simoll wrote:
> Is this a related change? (same in l265).
Kind of.  EncoderMethod will be called from MC layer.  However, we merged not-defined encoder method like this, so I needed to remove it once until we add actual encoder function in following patches.  I will divide patches like below.

  # Fixes for the instruction bit encoding.
  # The 'EM_VE' ELF changes
  # Fixes for undefined methods like this.
  # The VEAsmParser and tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78698/new/

https://reviews.llvm.org/D78698