[PATCH] D78983: [ELF] Add --print-archive-stats=
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 28 00:29:45 PDT 2020
alexshap added inline comments.
================
Comment at: lld/ELF/InputFiles.cpp:1171
+ Error err = Error::success();
+ for (const Archive::Child &c : file->children(err)) {
+ (void)c;
----------------
1. what about
std::distance(file->child_begin(err), file->child_end()); ?
2. just curious why is the error consumed ? e.g. alternatively this could return Expected<...>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78983/new/
https://reviews.llvm.org/D78983
More information about the llvm-commits
mailing list